Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade lz4 to 4.3.2 on Python 3 #15746

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Sep 4, 2023

What does this PR do?

Upgrade lz4 to 4.3.2 on Python 3

Motivation

#15745 (review)

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Test Results

  20 files    20 suites   6m 25s ⏱️
  14 tests   12 ✔️   2 💤 0
150 runs  120 ✔️ 30 💤 0

Results for commit fa6e350.

@FlorentClarret FlorentClarret force-pushed the florentclarret/clickhouse/bump_lz4 branch from fa6e350 to f35cf75 Compare September 5, 2023 06:23
@ghost ghost added the documentation label Sep 5, 2023
@FlorentClarret FlorentClarret force-pushed the florentclarret/clickhouse/bump_lz4 branch from f35cf75 to 4cabbbf Compare September 5, 2023 06:24
@FlorentClarret FlorentClarret changed the title Bump lz4 version to 4.3.2 Upgrade lz4 to 4.3.2 on Python 3 Sep 5, 2023
@FlorentClarret FlorentClarret marked this pull request as ready for review September 5, 2023 06:25
@FlorentClarret FlorentClarret requested review from a team as code owners September 5, 2023 06:25
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #15746 (4cabbbf) into master (1da6596) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Flag Coverage Δ
clickhouse 95.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@alopezz
Copy link
Contributor

alopezz commented Sep 5, 2023

You might need to retrigger the validate-agent-build jobs, because they look like flakes, just to be sure.

@FlorentClarret
Copy link
Member Author

You might need to retrigger the validate-agent-build jobs, because they look like flakes, just to be sure.

Yup thanks! 🙇

@FlorentClarret
Copy link
Member Author

CI green! Merging

@FlorentClarret FlorentClarret merged commit c3b83b6 into master Sep 5, 2023
17 of 18 checks passed
@FlorentClarret FlorentClarret deleted the florentclarret/clickhouse/bump_lz4 branch September 5, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants