Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc update based on #9340 #15380

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Doc update based on #9340 #15380

merged 1 commit into from
Jul 27, 2023

Conversation

ian28223
Copy link
Contributor

What does this PR do?

Updates the README with username/password instead of the deprecated user/pass

Motivation

#9340

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@ian28223 ian28223 added documentation changelog/no-changelog qa/skip-qa Automatically skip this PR for the next QA labels Jul 26, 2023
@ian28223 ian28223 requested review from a team as code owners July 26, 2023 03:14
FlorentClarret
FlorentClarret approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@FlorentClarret FlorentClarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

alexandre-normand
alexandre-normand approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@alexandre-normand alexandre-normand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

buraizu
buraizu approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@FlorentClarret FlorentClarret merged commit 6adebe6 into master Jul 27, 2023
30 checks passed
@FlorentClarret FlorentClarret deleted the ian.bucad/doc_9340 branch July 27, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-normand alexandre-normand alexandre-normand approved these changes

@FlorentClarret FlorentClarret FlorentClarret approved these changes

@buraizu buraizu buraizu approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog documentation integration/mysql integration/oracle integration/supervisord qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ian28223 @alexandre-normand @FlorentClarret @buraizu