Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MapReduce] Adds skip ssl validation #1470

Merged
merged 3 commits into from
Apr 27, 2018
Merged

[MapReduce] Adds skip ssl validation #1470

merged 3 commits into from
Apr 27, 2018

Conversation

gmmeyer
Copy link
Contributor

@gmmeyer gmmeyer commented Apr 27, 2018

What does this PR do?

This adds the option to skip ssl validation for mapreduce.

Motivation

The check breaks when using a self signed cert

Versioning

  • Bumped the check version in manifest.json
  • Bumped the check version in datadog_checks/{integration}/__init__.py
  • Updated CHANGELOG.md. Please use Unreleased as the date in the title
    for the new section.
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

nmuesch
nmuesch approved these changes Apr 27, 2018
View reviewed changes
Copy link
Collaborator

@nmuesch nmuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🙇

@gmmeyer gmmeyer merged commit 76b3e4e into master Apr 27, 2018
@gmmeyer gmmeyer deleted the greg/skip-validation branch April 27, 2018 19:36
@gmmeyer gmmeyer added this to the 6.3 milestone Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmuesch nmuesch nmuesch approved these changes

Assignees
No one assigned
Labels
kind/feature-request
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@gmmeyer @nmuesch @masci