-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #14594
Update dependencies #14594
Conversation
The |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
The |
kafka_consumer/hatch.toml
Outdated
@@ -8,7 +8,7 @@ e2e-env = false | |||
# If you bump the `confluent-kafka` version, also bump the `librdkafka` version in the `32_install_kerberos.sh` file | |||
post-install-commands = [ | |||
"python -m pip uninstall -y confluent-kafka", | |||
"python -m pip install --no-binary confluent-kafka confluent-kafka==2.0.2", | |||
"python -m pip install --no-binary confluent-kafka confluent-kafka==2.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also bump this to v2.1.1
to (try to) fix the tests
The |
e94ca4b
to
7bbf52e
Compare
The |
f3def38
to
add8baa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
psutil==5.9.0 | ||
psycopg2-binary==2.8.6; sys_platform != 'darwin' or platform_machine != 'arm64' | ||
pyasn1==0.4.6 | ||
pycryptodomex==3.10.1 | ||
pydantic==1.10.4; python_version > '3.0' | ||
pydantic==1.10.7; python_version > '3.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we bump this to 1.10.8? I was testing something today on ddev and realized that some checks were broken, with failed to load errors. Turns out it's because of this issue:
pydantic/pydantic#5824
The fix is shipped with 1.10.8. I tested it by doing a pip install and re-running the check and it loads properly. I think we have to pin it to above that version
add8baa
to
38b9d4a
Compare
f4ffcf6
@@ -56,8 +56,8 @@ deps = [ | |||
"prometheus-client==0.12.0; python_version < '3.0'", | |||
"prometheus-client==0.16.0; python_version > '3.0'", | |||
"protobuf==3.17.3; python_version < '3.0'", | |||
"protobuf==3.20.2; python_version > '3.0'", | |||
"pydantic==1.10.4; python_version > '3.0'", | |||
"protobuf==4.23.1; python_version > '3.0'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one I think I had an issue with last time I tried bumping back in 7.42.x
f4ffcf6
to
b78f29c
Compare
"protobuf==3.20.2; python_version > '3.0'", | ||
"pydantic==1.10.4; python_version > '3.0'", | ||
"protobuf==4.23.1; python_version > '3.0'", | ||
"pydantic==1.10.8; python_version > '3.0'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update the version here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
What does this PR do?
Bump some dependencies.
Motivation
Preparation for release.
Additional Notes
confluent-kafka requires an update on omnibus, DataDog/datadog-agent#17266.We're postponing the confluent-kafka update as it requires some extra care.Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.