Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OAuth #14184

Closed

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented Mar 17, 2023

What does this PR do?

This PR implements OAuth config options for the confluent-kafka-python implementation of the kafka_consumer check.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@yzhan289 yzhan289 marked this pull request as ready for review March 17, 2023 21:02
@yzhan289 yzhan289 requested a review from a team as a code owner March 17, 2023 21:02
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #14184 (154d085) into AI-2904/kafka-consumer-revamp (9613334) will increase coverage by 0.05%.
The diff coverage is n/a.

Flag Coverage Δ
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
arangodb 98.21% <ø> (ø)
argocd 88.43% <ø> (ø)
aspdotnet 100.00% <ø> (+26.19%) ⬆️
azure_iot_edge 82.00% <ø> (ø)
cisco_aci 95.27% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
cloudera 99.82% <ø> (ø)
cockroachdb 90.96% <ø> (ø)
consul 91.64% <ø> (ø)
coredns 94.54% <ø> (ø)
datadog_checks_downloader 80.48% <ø> (ø)
ddev 98.64% <ø> (ø)
directory 96.20% <ø> (ø)
dns_check 93.90% <ø> (ø)
dotnetclr 94.93% <ø> (+15.18%) ⬆️
druid 97.70% <ø> (ø)
ecs_fargate 80.92% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
fluentd 94.77% <ø> (ø)
foundationdb 78.50% <ø> (ø)
go_expvar 92.73% <ø> (ø)
gunicorn 92.85% <ø> (ø)
hazelcast 92.39% <ø> (ø)
hdfs_namenode 86.72% <ø> (ø)
http_check 95.82% <ø> (+2.15%) ⬆️
impala 97.97% <ø> (ø)
istio 77.43% <ø> (+0.55%) ⬆️
kube_controller_manager 96.00% <ø> (ø)
kube_dns 95.97% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 96.53% <ø> (ø)
kubelet 90.96% <ø> (ø)
kubernetes_state 89.18% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linkerd 85.14% <ø> (+1.14%) ⬆️
linux_proc_extras 96.22% <ø> (ø)
mapr 82.70% <ø> (ø)
marathon 83.12% <ø> (ø)
mcache 93.50% <ø> (ø)
mesos_master 89.75% <ø> (ø)
mesos_slave 93.63% <ø> (ø)
nagios 89.01% <ø> (ø)
network 93.43% <ø> (+0.39%) ⬆️
nginx_ingress_controller 98.36% <ø> (ø)
openmetrics 97.90% <ø> (ø)
openstack 51.45% <ø> (ø)
postfix 88.04% <ø> (ø)
powerdns_recursor 96.65% <ø> (ø)
process 85.42% <ø> (+0.28%) ⬆️
prometheus 94.17% <ø> (ø)
proxysql 98.97% <ø> (ø)
pulsar 100.00% <ø> (ø)
riak 99.22% <ø> (ø)
silk 93.51% <ø> (ø)
singlestore 90.81% <ø> (ø)
statsd 87.36% <ø> (+1.05%) ⬆️
tokumx 58.40% <ø> (ø)
traffic_server 96.13% <ø> (ø)
twistlock 79.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret FlorentClarret force-pushed the florentclarret/kafka-consumer/tls branch 2 times, most recently from 7f1cde4 to 3f72752 Compare March 20, 2023 07:09
@FlorentClarret FlorentClarret mentioned this pull request Mar 20, 2023
5 tasks
@FlorentClarret FlorentClarret force-pushed the florentclarret/kafka-consumer/tls branch 9 times, most recently from a2db808 to 6582ab8 Compare March 23, 2023 08:42
Base automatically changed from florentclarret/kafka-consumer/tls to AI-2904/kafka-consumer-revamp March 24, 2023 09:18
@FlorentClarret FlorentClarret mentioned this pull request Mar 27, 2023
5 tasks
@yzhan289
Copy link
Contributor Author

Closing in favor of #14247

@yzhan289 yzhan289 closed this Mar 27, 2023
@ofek ofek deleted the 03-17-Oauth-implementation branch March 27, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment