Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp Kafka consumer check #13918
Revamp Kafka consumer check #13918
Changes from 1 commit
99d8545
5fad2df
64cfd17
d656496
8cbbb42
7661573
ff2adfa
dcaf7a4
ea70817
d1e23e6
71925f4
1efecf5
4bc5d72
54270d1
9445ce6
464cedb
9d6bc06
f3d491f
c7c5f23
cbc9499
d73b7cf
9ec25cb
29d72d4
ef4d252
cf4e083
8613a9a
47b3e79
c122a42
734439b
8dab1dd
0a84c96
06880c7
07cedd3
74e3b19
feaf069
eff52d1
03cd475
fda2758
18cf334
a6fd4d9
7f6409f
4be6ab7
e8e800c
7a6a962
c258d73
24c5cf7
46b6745
35f2639
926a1d8
13a8fd3
df4e4f1
65751ea
11aae44
f39cb7c
26b607d
0902b3c
682c703
7d53dd4
8c4bb33
206b544
ac7e5ac
674db3d
2d23ca1
8b61e65
01a7d1b
c878425
bbc8cdb
58a69f9
9613334
493a4d2
9f13a59
9093016
1c70ff9
4dc1e1c
3fd3166
bd21f05
3e4b54d
53a74b4
80e2eb7
da6666e
cb01ec3
79b8927
5d6e062
4a33136
a093a2b
c5e6c6b
5ccdc25
558307c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave this for later, but we don't really need the
else
block here anymore since theexcept
clause already returns early. Removing theelse
makes it more clear what the main ("happy") path of the function is.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, we can reduce the extra nesting by
continue
ing when we catch the exception and keeping the main code out of the try-except.