Remove the use of the deprecated pkg_resources package
#13842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
fridex
previously approved these changes
Jan 31, 2023
|
The |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
The |
| @@ -28,7 +28,7 @@ def substitute(target_relpath): | |||
| if not wheel_distribution_name.startswith('datadog_'): | |||
| raise NonDatadogPackage(wheel_distribution_name) | |||
|
|
|||
| standard_distribution_name = safe_name(wheel_distribution_name) | |||
| standard_distribution_name = canonicalize_name(wheel_distribution_name) | |||
There was a problem hiding this comment.
@ofek have you checked that this function does the same thing? I assume you have, but just double-checking.
olivielpeau
reviewed
Jan 31, 2023
Comment on lines
-109
to
-110
| def get_library_versions(cls): | ||
| return {"memcache": pkg_resources.get_distribution("python-binary-memcached").version} |
There was a problem hiding this comment.
This function is entirely removed, is there no alternative to using pkg_resources to implement this function?
There was a problem hiding this comment.
this was not being used by anything so I simply removed it
trishankatdatadog
approved these changes
Jan 31, 2023
iliakur
approved these changes
Jan 31, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
* Remove the use of the deprecated `pkg_resources` package * pin * Update LICENSE-3rdparty.csv * fix test 029e00f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Notes
This package is also used in a few test suites but that will be a separate PR so changelogs don't get affected