-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the use of the deprecated pkg_resources
package
#13842
Conversation
The |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
The |
@@ -28,7 +28,7 @@ def substitute(target_relpath): | |||
if not wheel_distribution_name.startswith('datadog_'): | |||
raise NonDatadogPackage(wheel_distribution_name) | |||
|
|||
standard_distribution_name = safe_name(wheel_distribution_name) | |||
standard_distribution_name = canonicalize_name(wheel_distribution_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ofek have you checked that this function does the same thing? I assume you have, but just double-checking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For our use case, yes
def get_library_versions(cls): | ||
return {"memcache": pkg_resources.get_distribution("python-binary-memcached").version} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is entirely removed, is there no alternative to using pkg_resources
to implement this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was not being used by anything so I simply removed it
* Remove the use of the deprecated `pkg_resources` package * pin * Update LICENSE-3rdparty.csv * fix test 029e00f
Additional Notes
This package is also used in a few test suites but that will be a separate PR so changelogs don't get affected