-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run cloudera manager requests in parallel #13499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
documentation
label
Dec 12, 2022
yzhan289
changed the title
Cloudera multithread
Run cloudera manager requests in parallel
Dec 13, 2022
yzhan289
added a commit
that referenced
this pull request
Dec 23, 2022
* Cloudera template * Outline plan for integration * Set up init metric and test env * Add common.py * Outline check and include tests * Clean up check * Update cloudera/pyproject.toml Co-authored-by: Ofek Lev <[email protected]> * Drop support for Python 2 * Clean up timeseries metrics * Add more metrics * Add more metrics * Implement host service check and fix style * Change how cloudera client is created * Add caddy to mock API output * Add caddy test API outputs * Apply Jose's metric and health check collection style (#13423) * First commit * Added docker-compose file * Match current PR * Match PR * Fix style * Refactor * Revert any test changes * Spacing * Revert unnecessary changes * Spacing Co-authored-by: Jose Manuel Almaza <[email protected]> * Apply testing changes (#13424) * Apply changes from Jose's branch * Add Jose's new host metrics * Fix validations * Add license * Fix properties * Change to use caddy docker image * Start events implementation * Unit tests working * Map to 80 local port not recommended * Added url to debug log * Remove events implementation * Fixed integration tests * Fix license validation * Remove unused constants * Add e2e test * Use master's change * Fix e2e and integration test style * Add temporary gitlab change * Temporarily add default dep * Wait for Cloudera is up * Refactor Cloudera (#13460) * Add native host metrics * Remove unused function name * Refactor Cloudera * Remove native metric support * Fix style * Update refactor from feedback * Update service checks and update metadata.csv * Fixed missing coverage * Added 'io' to VALID_UNIT_NAMES * Added some tag checks to tests * Fix service checks and add comma * Add native metrics (#13474) * Add native metrics * Fix e2e test * Move metadata.csv change to separate branch * Renamed some methods * Fixed problem merging metrics * Fixed unit tests Co-authored-by: Jose Manuel Almaza <[email protected]> * Clean up * Add version collection * Add back service check for can_connect * Update README and add pictures * Move images directory * Add custom tag support * Fix style * Add custom tag tests * Fix test for e2e test * Run cloudera manager requests in parallel (#13499) * Added multithread * Add hidden config for max connection pool size * Added 'dd_environment' to test_metadata * Update config Co-authored-by: Andrew Zhang <[email protected]> * Fix config param * Remove io as metric type * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions * Apply suggestion * Fix style * Update cloudera/README.md Co-authored-by: Bryce Eadie <[email protected]> * Update cloudera/README.md Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions * Fix tests * Fix style * Fix formatting * Apply suggestion and move credentials to init_config * Update Cloudera README for collecting metrics * Fix README * Fix README * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> Co-authored-by: Ofek Lev <[email protected]> Co-authored-by: Jose Manuel Almaza <[email protected]> Co-authored-by: Bryce Eadie <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Dec 23, 2022
* Cloudera template * Outline plan for integration * Set up init metric and test env * Add common.py * Outline check and include tests * Clean up check * Update cloudera/pyproject.toml Co-authored-by: Ofek Lev <[email protected]> * Drop support for Python 2 * Clean up timeseries metrics * Add more metrics * Add more metrics * Implement host service check and fix style * Change how cloudera client is created * Add caddy to mock API output * Add caddy test API outputs * Apply Jose's metric and health check collection style (#13423) * First commit * Added docker-compose file * Match current PR * Match PR * Fix style * Refactor * Revert any test changes * Spacing * Revert unnecessary changes * Spacing Co-authored-by: Jose Manuel Almaza <[email protected]> * Apply testing changes (#13424) * Apply changes from Jose's branch * Add Jose's new host metrics * Fix validations * Add license * Fix properties * Change to use caddy docker image * Start events implementation * Unit tests working * Map to 80 local port not recommended * Added url to debug log * Remove events implementation * Fixed integration tests * Fix license validation * Remove unused constants * Add e2e test * Use master's change * Fix e2e and integration test style * Add temporary gitlab change * Temporarily add default dep * Wait for Cloudera is up * Refactor Cloudera (#13460) * Add native host metrics * Remove unused function name * Refactor Cloudera * Remove native metric support * Fix style * Update refactor from feedback * Update service checks and update metadata.csv * Fixed missing coverage * Added 'io' to VALID_UNIT_NAMES * Added some tag checks to tests * Fix service checks and add comma * Add native metrics (#13474) * Add native metrics * Fix e2e test * Move metadata.csv change to separate branch * Renamed some methods * Fixed problem merging metrics * Fixed unit tests Co-authored-by: Jose Manuel Almaza <[email protected]> * Clean up * Add version collection * Add back service check for can_connect * Update README and add pictures * Move images directory * Add custom tag support * Fix style * Add custom tag tests * Fix test for e2e test * Run cloudera manager requests in parallel (#13499) * Added multithread * Add hidden config for max connection pool size * Added 'dd_environment' to test_metadata * Update config Co-authored-by: Andrew Zhang <[email protected]> * Fix config param * Remove io as metric type * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions * Apply suggestion * Fix style * Update cloudera/README.md Co-authored-by: Bryce Eadie <[email protected]> * Update cloudera/README.md Co-authored-by: Bryce Eadie <[email protected]> * Apply suggestions * Fix tests * Fix style * Fix formatting * Apply suggestion and move credentials to init_config * Update Cloudera README for collecting metrics * Fix README * Fix README * Apply suggestions from code review Co-authored-by: Bryce Eadie <[email protected]> Co-authored-by: Ofek Lev <[email protected]> Co-authored-by: Jose Manuel Almaza <[email protected]> Co-authored-by: Bryce Eadie <[email protected]> 28ad542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.