Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kafka request metrics due to KIP 272 #13232

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented Oct 28, 2022

What does this PR do?

In KIP-272, all RequestsPerSec metric bean names were changed from
kafka.network:type=RequestMetrics,name=RequestsPerSec,request={Produce|FetchConsumer|FetchFollower|...}

to
kafka.network:type=RequestMetrics,name=RequestsPerSec,request={Produce|FetchConsumer|FetchFollower|...},version=INTEGER

This caused our current RequestsPerSec metrics to no longer be collected. This wasn't discovered until recently because our current e2e environment doesn't collect the missing metrics in the first place.

This PR updates the bean name to be a regex and allow it to collect the version number if it exists, but retains backwards compatibility with the original style.

Motivation

Support case

Additional Notes

We should consider using a more official Kafka image, since our version is a major version release behind the current version of Kafka. Here's an alternate image we can consider using.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@ghost ghost added the integration/kafka label Oct 28, 2022
@yzhan289 yzhan289 marked this pull request as ready for review October 28, 2022 18:49
@yzhan289 yzhan289 requested a review from a team as a code owner October 28, 2022 18:49
fanny-jiang
fanny-jiang previously approved these changes Oct 28, 2022
kafka/metadata.csv Outdated Show resolved Hide resolved
steveny91
steveny91 previously approved these changes Oct 28, 2022
@yzhan289 yzhan289 merged commit 1a3ad90 into master Nov 7, 2022
@yzhan289 yzhan289 deleted the az/fix-kafka-requests-metrics branch November 7, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants