Fix kafka request metrics due to KIP 272 #13232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In KIP-272, all
RequestsPerSec
metric bean names were changed fromkafka.network:type=RequestMetrics,name=RequestsPerSec,request={Produce|FetchConsumer|FetchFollower|...}
to
kafka.network:type=RequestMetrics,name=RequestsPerSec,request={Produce|FetchConsumer|FetchFollower|...},version=INTEGER
This caused our current
RequestsPerSec
metrics to no longer be collected. This wasn't discovered until recently because our current e2e environment doesn't collect the missing metrics in the first place.This PR updates the bean name to be a regex and allow it to collect the version number if it exists, but retains backwards compatibility with the original style.
Motivation
Support case
Additional Notes
We should consider using a more official Kafka image, since our version is a major version release behind the current version of Kafka. Here's an alternate image we can consider using.
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.