Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix openmetrics v2 service check: there shouldn’t be any host #13146

Merged
merged 8 commits into from
Oct 27, 2022
Merged

Fix openmetrics v2 service check: there shouldn’t be any host #13146

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0b658e1
Fix openmetrics v2 service check: there shouldn’t be any host
L3n41c Oct 17, 2022
e9af726
Fix (attempt)
L3n41c Oct 17, 2022
a7c0c67
Revert "Fix (attempt)"
L3n41c Oct 18, 2022
a2efeac
Move type annotation to `hostname` attribute definition
L3n41c Oct 18, 2022
36eb394
Move the fix to openmetrics v2 specific code to reduce the impact
L3n41c Oct 18, 2022
4dfd966
Attempt to fix tests
L3n41c Oct 24, 2022
d1d1f96
Revert "Attempt to fix tests"
L3n41c Oct 27, 2022
e5db34f
Attempt to fix tests
L3n41c Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion datadog_checks_base/datadog_checks/base/checks/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,10 @@ def __init__(self, *args, **kwargs):
self.debug_metrics.update(self.instance.get('debug_metrics', {}))

# `self.hostname` is deprecated, use `datadog_agent.get_hostname()` instead
self.hostname = datadog_agent.get_hostname() # type: str
if self.instance is not None and self.instance.get('empty_default_hostname', False):
self.hostname = ""
else:
self.hostname = datadog_agent.get_hostname() # type: str

logger = logging.getLogger('{}.{}'.format(__name__, self.name))
self.log = CheckLoggingAdapter(logger, self)
Expand Down