-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ibm_i integration produces CRITICAL service check if it cannot connect #13114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍 Left a nit comment
Also, this PR shoud have the no-changelog
label because the tests are not shipped with the agent. The changelog only contains code modifications that are bundled with the agent.
Last thing, you can mention the link to the jira card you're working on (if any) in the description
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
4372875
to
ac25691
Compare
The |
Co-authored-by: Fanny Jiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
#13114) * Add e2e test for ibm_i integration. Co-authored-by: Fanny Jiang <[email protected]> Co-authored-by: Fanny Jiang <[email protected]> 7bc04d4
#13114) * Add e2e test for ibm_i integration. Co-authored-by: Fanny Jiang <[email protected]> Co-authored-by: Fanny Jiang <[email protected]>
What does this PR do?
As part of adding e2e tests for the ibm_i integration, we change it to emit a CRITICAL service check in case we cannot connect to an IBM-I machine.
Motivation
Part of work on this:
https://datadoghq.atlassian.net/browse/AI-1760
Additional Notes
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attachedqa/skip-qa
label.