ibm_i integration produces CRITICAL service check if it cannot connect #13114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
There was a problem hiding this comment.
Looks good! 👍 Left a nit comment
Also, this PR shoud have the no-changelog label because the tests are not shipped with the agent. The changelog only contains code modifications that are bundled with the agent.
Last thing, you can mention the link to the jira card you're working on (if any) in the description
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
iliakur
commented
Oct 14, 2022
fanny-jiang
reviewed
Oct 14, 2022
iliakur
force-pushed
the
iliakurenkov/ibm_i-e2e-test
branch
from
4372875
to
ac25691
Compare
|
The |
iliakur
changed the title
fanny-jiang
reviewed
Oct 25, 2022
Co-authored-by: Fanny Jiang <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
#13114) * Add e2e test for ibm_i integration. Co-authored-by: Fanny Jiang <[email protected]> Co-authored-by: Fanny Jiang <[email protected]> 7bc04d4
steveny91
pushed a commit
that referenced
this pull request
Oct 27, 2022
#13114) * Add e2e test for ibm_i integration. Co-authored-by: Fanny Jiang <[email protected]> Co-authored-by: Fanny Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As part of adding e2e tests for the ibm_i integration, we change it to emit a CRITICAL service check in case we cannot connect to an IBM-I machine.
Motivation
Part of work on this:
https://datadoghq.atlassian.net/browse/AI-1760
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attachedqa/skip-qalabel.