Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent fork bomb when defining the experimental process_isolation option globally in the init_config section #13091

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

fanny-jiang
Copy link
Contributor

What does this PR do?

Fixes fork bomb and CPU overconsumption when using process_isolation: true in the init_config.

Motivation

QA #12986

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@fanny-jiang fanny-jiang requested a review from a team as a code owner October 11, 2022 21:07
@ghost ghost added the base_package label Oct 11, 2022
@fanny-jiang fanny-jiang added changelog/Fixed category/bugfix For use during Agent Release period labels Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #13091 (0ea0e19) into master (87a8419) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Flag Coverage Δ
active_directory 100.00% <ø> (+17.64%) ⬆️
airflow 90.00% <ø> (ø)
amazon_msk 88.67% <ø> (ø)
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
arangodb 98.21% <ø> (ø)
aspdotnet 100.00% <ø> (+26.19%) ⬆️
avi_vantage 92.50% <ø> (ø)
azure_iot_edge 82.00% <ø> (ø)
boundary 100.00% <ø> (ø)
btrfs 82.91% <ø> (ø)
cacti 87.90% <ø> (ø)
calico 83.33% <ø> (ø)
cassandra_nodetool 93.16% <ø> (ø)
ceph 91.02% <ø> (ø)
cert_manager 77.41% <ø> (ø)
cilium 75.34% <ø> (+0.93%) ⬆️
cisco_aci 95.27% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
clickhouse 95.31% <ø> (ø)
cloud_foundry_api 95.98% <ø> (+0.12%) ⬆️
cockroachdb 97.36% <ø> (ø)
consul 91.64% <ø> (ø)
coredns 94.54% <ø> (ø)
couch 95.19% <ø> (+0.36%) ⬆️
crio 89.79% <ø> (ø)
datadog_checks_base 89.78% <100.00%> (+0.35%) ⬆️
datadog_checks_dev 80.42% <ø> (ø)
datadog_checks_downloader 78.82% <ø> (+0.95%) ⬆️
datadog_cluster_agent 90.00% <ø> (ø)
ddev 98.09% <ø> (ø)
directory 94.94% <ø> (ø)
disk 91.61% <ø> (+6.31%) ⬆️
dns_check 93.90% <ø> (ø)
dotnetclr 94.93% <ø> (+15.18%) ⬆️
druid 97.70% <ø> (ø)
ecs_fargate 80.05% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
elastic 91.61% <ø> (ø)
envoy 94.23% <ø> (ø)
etcd 93.96% <ø> (+0.28%) ⬆️
exchange_server 96.85% <ø> (+11.81%) ⬆️
external_dns 89.09% <ø> (ø)
fluentd 94.77% <ø> (ø)
foundationdb 83.88% <ø> (ø)
gitlab 89.94% <ø> (ø)
glusterfs 80.09% <ø> (+0.92%) ⬆️
haproxy 95.12% <ø> (+0.16%) ⬆️
harbor 80.04% <ø> (ø)
hazelcast 92.39% <ø> (ø)
hdfs_datanode 89.74% <ø> (ø)
hdfs_namenode 86.72% <ø> (ø)
http_check 95.38% <ø> (+2.08%) ⬆️
ibm_db2 95.10% <ø> (ø)
ibm_i 82.28% <ø> (ø)
ibm_mq 90.46% <ø> (ø)
ibm_was 96.06% <ø> (ø)
iis 94.55% <ø> (+39.22%) ⬆️
impala 97.97% <ø> (ø)
istio 77.65% <ø> (+0.55%) ⬆️
kafka_consumer 84.41% <ø> (ø)
kong 88.06% <ø> (ø)
kube_apiserver_metrics 97.67% <ø> (ø)
kube_controller_manager 96.85% <ø> (ø)
kube_metrics_server 100.00% <ø> (ø)
kube_proxy 100.00% <ø> (ø)
kube_scheduler 97.14% <ø> (ø)
kubelet 90.85% <ø> (ø)
kubernetes_state 89.35% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
linkerd 85.14% <ø> (+1.14%) ⬆️
linux_proc_extras 96.22% <ø> (ø)
mapr 82.70% <ø> (ø)
mapreduce 81.30% <ø> (-0.47%) ⬇️
marathon 83.12% <ø> (ø)
marklogic 96.03% <ø> (ø)
mcache 93.26% <ø> (ø)
mesos_master 89.75% <ø> (ø)
mesos_slave 93.63% <ø> (ø)
mongo 96.49% <ø> (ø)
nagios 89.01% <ø> (ø)
network 52.00% <ø> (-31.81%) ⬇️
nfsstat 95.20% <ø> (ø)
nginx 95.24% <ø> (+0.54%) ⬆️
nginx_ingress_controller 98.36% <ø> (ø)
openldap 96.33% <ø> (ø)
openmetrics 97.90% <ø> (ø)
openstack 51.45% <ø> (ø)
openstack_controller 90.94% <ø> (ø)
oracle 91.39% <ø> (+2.45%) ⬆️
pdh_check 95.65% <ø> (ø)
pgbouncer 91.33% <ø> (ø)
php_fpm 90.25% <ø> (+0.84%) ⬆️
postfix 88.04% <ø> (ø)
process 85.07% <ø> (+0.28%) ⬆️
prometheus 94.17% <ø> (ø)
proxysql 98.97% <ø> (ø)
pulsar 100.00% <ø> (ø)
rabbitmq 94.41% <ø> (ø)
redisdb 87.50% <ø> (ø)
rethinkdb 97.93% <ø> (ø)
riak 99.22% <ø> (ø)
riakcs 93.61% <ø> (ø)
scylla 100.00% <ø> (ø)
silk 93.33% <ø> (ø)
snmp 86.11% <ø> (+0.04%) ⬆️
snowflake 96.47% <ø> (ø)
sonarqube 95.73% <ø> (ø)
spark 93.83% <ø> (+0.28%) ⬆️
squid 100.00% <ø> (ø)
ssh_check 91.58% <ø> (ø)
statsd 87.36% <ø> (+1.05%) ⬆️
supervisord 92.30% <ø> (ø)
system_core 92.85% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 91.58% <ø> (ø)
teamcity 80.00% <ø> (ø)
teradata 94.24% <ø> (ø)
tls 91.85% <ø> (+0.84%) ⬆️
tokumx 58.40% <ø> (?)
traffic_server 96.13% <ø> (ø)
twemproxy 79.45% <ø> (ø)
varnish 84.39% <ø> (+0.26%) ⬆️
vault 95.53% <ø> (+0.57%) ⬆️
vertica 98.50% <ø> (ø)
voltdb 96.84% <ø> (ø)
win32_event_log 86.40% <ø> (+0.27%) ⬆️
windows_performance_counters 98.36% <ø> (ø)
windows_service 98.00% <ø> (ø)
wmi_check 92.91% <ø> (ø)
yarn 89.14% <ø> (ø)
zk 86.23% <ø> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek ofek changed the title Prevent init_config fork bomb Prevent fork bomb when defining the experimental process_isolation option globally in the init_config section Oct 11, 2022
@FlorentClarret FlorentClarret merged commit 35b3c1a into master Oct 12, 2022
@FlorentClarret FlorentClarret deleted the fanny/process-isolation branch October 12, 2022 07:16
FlorentClarret pushed a commit that referenced this pull request Oct 12, 2022
FlorentClarret added a commit that referenced this pull request Oct 12, 2022
(cherry picked from commit 35b3c1a)

Co-authored-by: Fanny Jiang <[email protected]>
steveny91 pushed a commit that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base_package category/bugfix For use during Agent Release period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants