Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube_state] add kubernetes_state.nodes.by_condition count #1277

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Mar 19, 2018

What does this PR do?

Add a count metric kubernetes_state.nodes.by_condition extracted from the kube_node_status_condition ksm metric.

Current known tag values:

  • condition:
    • MemoryPressure
    • DiskPressure
    • OutOfDisk
    • Ready
  • status:
    • true
    • false
    • unknown

Aggregation is done client-side, and we report zeroes for all statuses to avoid non-data graphing issues. That makes for 12 new timeseries per cluster. Node-specific state is visible via the existing service checks.

Motivation

Although the kubernetes_state.node.* service check allow to set alerts, we cannot graph them. This count could allow a user to graph their ready node count alongside their autoscaling group size for example. This count would not superseede the existing SCs, that offer node granularity.

Having node granularity on these counts would bring the no data issues we have with kubernetes_state.pod.ready when churning.

Versioning

  • Bumped the check version in manifest.json
  • Bumped the check version in datadog_checks/{integration}/__init__.py
  • Updated CHANGELOG.md. Please use Unreleased as the date in the title
    for the new section.
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

Anything else we should know when reviewing?

@xvello xvello added this to the 5.23.0 milestone Mar 19, 2018
@xvello xvello force-pushed the xvello/ksm-node-bycondition branch from 8d86943 to f2c177a Compare March 19, 2018 15:34
Copy link
Contributor

@mfpierre mfpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xvello xvello merged commit 424f23f into master Mar 19, 2018
@xvello xvello deleted the xvello/ksm-node-bycondition branch March 19, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants