Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom messages in QueryManager queries of type 'service_check' #12537

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

alopezz
Copy link
Contributor

@alopezz alopezz commented Jul 19, 2022

What does this PR do?

Adds a way to dynamically set the message field on queries of service_check type, based on columns from the same query, via str.format-based placeholders. It disables the message (sets it to None) when the reported check status is OK.

Motivation

I'm working on refactoring the Vertica integration to make use of the QueryManager and I need to be able to set the message to avoid a change in behavior.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #12537 (0a7e979) into master (80c44c4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
activemq_xml 82.31% <ø> (ø)
arangodb 98.21% <ø> (ø)
avi_vantage 91.92% <ø> (ø)
calico 83.33% <ø> (ø)
kube_proxy 100.00% <ø> (ø)
linkerd 85.14% <ø> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@alopezz alopezz merged commit 789ab46 into master Jul 19, 2022
@alopezz alopezz deleted the alopez/base/query-service-check-message branch July 19, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants