Fix bug where mysql table row stats were not being collected #12472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jmeunier28
commented
Jul 7, 2022
| @@ -401,6 +401,7 @@ def _collect_metrics(self, db, tags): | |||
|
|
|||
| if is_affirmative(self._config.options.get('table_rows_stats_metrics', False)) and self.userstat_enabled: | |||
| # report size of tables in MiB to Datadog | |||
| self.log.debug("Collecting Table Row Stats Metrics.") | |||
There was a problem hiding this comment.
added this bc other functions above have it as well e.g. https://github.com/DataDog/integrations-core/pull/12472/files#diff-4ecc52a59650f90cba9b1b1b3a145f8dc3457d133fc52419846c63e62bbe9bd8R383
alexandre-normand
approved these changes
Jul 7, 2022
|
here are the metrics being reported on our test database
note: its a monotonic count and |
ofek
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to this PR #11043
Updates metadata.csv to reflect correct metric name,
mysql.info.table.rows.changedand fixes thetable_rows_stats_metricsconfig option look up, so metrics are properly reportedMotivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached