Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rows with empty SQL text in DBM Activity Query #12393

Merged
merged 7 commits into from
Jun 24, 2022
Merged

Fix rows with empty SQL text in DBM Activity Query #12393

merged 7 commits into from
Jun 24, 2022

Conversation

alexbarksdale
Copy link
Member

@alexbarksdale alexbarksdale commented Jun 22, 2022 •
edited
Loading

What does this PR do?

Updates MySQL's query activity query.

Query author and expert: @kyle-hailey

Motivation

The previous iteration of this query included rows without SQL text due to an incorrect outer JOIN statement in conjunction with the inner SELECT statement.

Additional Notes

Behavior from the previous iteration of the query:

  • Notice we receive many rows without SQL text

Screen Shot 2022-06-23 at 5 05 35 PM

New query:
Screen Shot 2022-06-23 at 5 33 37 PM

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Jun 22, 2022 •
edited
Loading

Codecov Report

Merging #12393 (46d4fbf) into master (10c94eb) will increase coverage by 0.01%.
The diff coverage is n/a.

Flag Coverage Δ
mysql 88.09% <ø> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@alexbarksdale alexbarksdale marked this pull request as ready for review June 23, 2022 21:35
@alexbarksdale alexbarksdale requested review from a team as code owners June 23, 2022 21:35
@justiniso justiniso changed the title Update query activity query Fix rows with empty SQL text in DBM Activity Query Jun 24, 2022
@alexbarksdale alexbarksdale merged commit cdaf2d3 into master Jun 24, 2022
@alexbarksdale alexbarksdale deleted the alex.barksdale/update-mysql-activity-query branch June 24, 2022 00:48
github-actions bot pushed a commit that referenced this pull request Jun 24, 2022
@alexbarksdale
Fix rows with empty SQL text in DBM Activity Query (#12393)
f2091fd 
* Update activity query

* rename column event_name -> wait_event

* Linter

* Query update

* Add documentation

* Fix linting

* Fallback to 'other' cdaf2d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justiniso justiniso justiniso approved these changes

Assignees
No one assigned
Labels
integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexbarksdale @justiniso