Fix missing import in PHP-FPM's check #12365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the PHP-FPM status read out using FastCGI.
sys
is used in determining the default encoding when retrieving the data onFCGI_STDERR
in Python 3. Failing to import it causes the plugin to crash.Motivation
We'd like to collect metrics from & monitor our PHP-FPM instances using DataDog, but we don't want to expose those metrics using HTTP.
Additional Notes
There are no tests for handling the UNIX path case, but we configured our instances such that they are only accessible by a UNIX socket. I'm unsure as to how to add those tests. If you need tests, I'd like to give a try adding them.
I've also searched the issue list before creating this PR, and it seems #11480 was already created but closed, due to the fact that the bug report was incomplete.
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached