Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change refreshing counters log level to debug #12069

Merged
merged 2 commits into from
May 27, 2022

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented May 23, 2022

Client feels as though events related to performance counters ("Refreshing counters for performance object..." and "Collecting query data for performance object...") are filling up their INFO level logs too quickly. They would like for us to downgrade performance counter events to DEBUG level.

@hithwen hithwen requested review from a team as code owners May 23, 2022 11:07
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #12069 (0be3b34) into master (2f40237) will not change coverage.
The diff coverage is 0.00%.

Flag Coverage Δ
ambari 85.75% <ø> (ø)
arangodb 95.74% <ø> (ø)
btrfs 82.91% <ø> (ø)
datadog_cluster_agent 90.00% <ø> (ø)
directory 94.87% <ø> (ø)
ibm_i 81.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, but I don't know who goes looking for these logs -- are they often used in support requests?

@hithwen
Copy link
Contributor Author

hithwen commented May 27, 2022

Seems reasonable to me, but I don't know who goes looking for these logs -- are they often used in support requests?

We usually request debug flares on support cases anyway

@hithwen hithwen merged commit a682686 into master May 27, 2022
@hithwen hithwen deleted the js/AI-2398-change-log-level branch May 27, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants