Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBM-1269: Track method execution statistics #12048

Closed

Conversation

alexbarksdale
Copy link
Member

What does this PR do?

Decorates mysql methods to track performance with the new tracked_method decorator.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@alexbarksdale alexbarksdale changed the title Track method execution statistics DBM-1269: Track method execution statistics May 18, 2022
@alexbarksdale alexbarksdale marked this pull request as ready for review May 18, 2022 18:13
@alexbarksdale alexbarksdale requested review from a team as code owners May 18, 2022 18:13
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #12048 (8a8d970) into master (6e7254a) will decrease coverage by 1.94%.
The diff coverage is 100.00%.

❗ Current head 8a8d970 differs from pull request most recent head d1f220d. Consider uploading reports for the commit d1f220d to get more accurate results

Flag Coverage Δ
argocd ?
boundary ?
cert_manager ?
cloudera ?
ddev ?
ibm_ace ?
impala ?
mysql 89.00% <100.00%> (+1.64%) ⬆️
teradata ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret
Copy link
Member

Hi @alexbarksdale 👋 Sorry for the delay but do we want this to be released with 7.40?

FlorentClarret
FlorentClarret previously approved these changes Dec 7, 2022
@FlorentClarret
Copy link
Member

Closing this PR since it's pretty old, feel free to re-open it if needed 🙂

@dd-devflow dd-devflow bot deleted the alex.barksdale/add-mysql-instrumentation branch February 7, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants