Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to ingest cloud_metadata for DBM host linking #11988

Merged
merged 6 commits into from
May 12, 2022

Conversation

jmeunier28
Copy link
Contributor

@jmeunier28 jmeunier28 commented May 10, 2022

What does this PR do?

Adds three new fields associated with the database-monitoring product in order to help support the new (beta) DB List feature. Ingesting this extra cloud related metadata will allow for us to link managed cloud resource metrics emitted by Datadog cloud crawlers to database-monitoring reported hosts.

Follow on PR to #11987

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #11988 (826cb5d) into master (194b7dd) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Flag Coverage Δ
mysql 88.91% <100.00%> (+1.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jmeunier28 jmeunier28 marked this pull request as ready for review May 12, 2022 16:47
@jmeunier28 jmeunier28 requested review from a team as code owners May 12, 2022 16:47
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@jmeunier28 jmeunier28 changed the title DBM-1197: Add (mysql) support to ingest cloud_metadata for DBM host linking Add support to ingest cloud_metadata for DBM host linking May 12, 2022
@jmeunier28 jmeunier28 merged commit caab6f6 into master May 12, 2022
@jmeunier28 jmeunier28 deleted the jmeunier/DBM-1197-mysql branch May 12, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants