Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback Kubernetes client version to 22.6 to avoid failures on non-standard POD conditions #11928

Merged
merged 1 commit into from
May 5, 2022
Merged

Fallback Kubernetes client version to 22.6 to avoid failures on non-standard POD conditions #11928

merged 1 commit into from
May 5, 2022

Conversation

vboulineau
Copy link
Contributor

What does this PR do?

In latest versions a check has been added on the values read from POD status sub-resource.
It can prevent some checks from running if a controller is setting non-standard conditions in status, with error like:

Error: Invalid value for `condition_type` (xxxx), must be one of ['ContainersReady', 'Initialized', 'PodScheduled', 'Ready']

Motivation

Bugfix.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@vboulineau vboulineau requested review from a team as code owners May 4, 2022 15:25
@codecov
Copy link

codecov bot commented May 4, 2022 •
edited
Loading

Codecov Report

Merging #11928 (ccacd8b) into master (8f38248) will increase coverage by 1.46%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_base 90.34% <ø> (+9.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@steveny91 steveny91 added the category/bugfix For use during Agent Release period label May 4, 2022
@vboulineau vboulineau merged commit 8719dc0 into master May 5, 2022
@vboulineau vboulineau deleted the vboulineau/fallback-kube-client branch May 5, 2022 07:34
vboulineau added a commit that referenced this pull request May 5, 2022
@vboulineau
Fallback Kubernetes client version to 22.6 to avoid failures on non-s…
da1d094 
…tandard POD conditions (#11928)
@vboulineau vboulineau mentioned this pull request May 5, 2022
Closed
4 tasks
steveny91 pushed a commit that referenced this pull request May 5, 2022
@vboulineau @steveny91
Fallback Kubernetes client version to 22.6 to avoid failures on non-s…
7f86d9e 
…tandard POD conditions (#11928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveny91 steveny91 steveny91 approved these changes

Assignees
No one assigned
Labels
category/bugfix For use during Agent Release period dependencies integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vboulineau @steveny91