Fix obfuscate_sql_with_metadata wrapper memory usage #11815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
djova
reviewed
Apr 11, 2022
djova
reviewed
Apr 11, 2022
alexbarksdale
added
bugfix/regression
category/bugfix
djova
approved these changes
Apr 12, 2022
steveny91
pushed a commit
that referenced
this pull request
Apr 12, 2022
* Update obfuscator wrapper * Cleanup * Check statement type * Handle whitespace and byte conversions * fix nit * Fix linting * Revert tests and add comment for context * Update comment * Update comment
This was referenced Apr 12, 2022
steveny91
pushed a commit
that referenced
this pull request
Apr 14, 2022
* Update obfuscator wrapper * Cleanup * Check statement type * Handle whitespace and byte conversions * fix nit * Fix linting * Revert tests and add comment for context * Update comment * Update comment
djova
added a commit
that referenced
this pull request
Apr 18, 2022
Follow-up to #11815. Changelog must be manually updated in case of a patch release for an older version.
4 tasks
djova
added a commit
that referenced
this pull request
Jun 22, 2022
Follow-up to #11815. Changelog must be manually updated in case of a patch release for an older version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the
obfuscate_sql_with_metadatawrapper to prevent unnecessarily throwing exceptions from decoding attempts. We found thatorjsonleaks memory when failing to parse these strings which are not valid json.Note, this change is only relevant when integrations are running on an agent before 7.34.
Relevant PR: DataDog/datadog-agent#10042
Motivation
Before
After
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached