Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kube_cronjob tag to job metrics when applicable #11692

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Add kube_cronjob tag to job metrics when applicable #11692

merged 1 commit into from
Mar 17, 2022

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Add kube_cronjob tag to job metrics when applicable

Motivation

Better UX + ease the migration to ksm core

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ahmed-mez ahmed-mez requested review from a team as code owners March 17, 2022 09:40
@codecov
Copy link

codecov bot commented Mar 17, 2022 •
edited
Loading

Codecov Report

Merging #11692 (adce510) into master (291903b) will increase coverage by 0.00%.
The diff coverage is 92.85%.

Flag Coverage Δ
kubernetes_state 89.78% <92.85%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

clamoriniere
clamoriniere approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ahmed-mez ahmed-mez merged commit b21da7f into master Mar 17, 2022
@ahmed-mez ahmed-mez deleted the ahmed/ksm-core-cronjob-ag branch March 17, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clamoriniere clamoriniere clamoriniere approved these changes

Assignees
No one assigned
Labels
integration/kubernetes_state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmed-mez @clamoriniere