Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml file #11369

Merged
merged 4 commits into from
Feb 9, 2022
Merged

Add pyproject.toml file #11369

merged 4 commits into from
Feb 9, 2022

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Feb 7, 2022

Motivation

Modernize packaging, continues #11233

ibm_i/setup.py Outdated
@@ -27,7 +27,22 @@ def get_dependencies():
return f.readlines()


CHECKS_BASE_REQ = 'datadog-checks-base>=21.0.0'
def parse_pyproject_array(name):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this integration is Python 3 only, do we still need the setup.py file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, addressed!

@ofek ofek merged commit 09c3729 into master Feb 9, 2022
@ofek ofek deleted the ofek/pyproject_ibm_i branch February 9, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants