[HDFS_Namenode] fix missing tags crash #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In DataDog#1107 a bug was introduced so that if no `tags` are specified on an instance, the check crashes: ``` hdfs_namenode (5.22.0) ---------------------- - instance #0 [ERROR]: "'NoneType' object has no attribute 'append'" Traceback (most recent call last): File "/opt/datadog-agent/agent/checks/__init__.py", line 812, in run self.check(copy.deepcopy(instance)) File "/opt/datadog-agent/embedded/lib/python2.7/site-packages/datadog_checks/hdfs_namenode/hdfs_namenode.py", line 99, in check tags.append('namenode_url:' + jmx_address) AttributeError: 'NoneType' object has no attribute 'append' ``` Temporary workaround for those that don't use tags is to simply set `tags: []` in your instance settings.
djova
changed the title
ofek
approved these changes
Feb 19, 2018
|
Hey @djova Thanks for the PR! I'll go ahead and merge this so we can get it released soon. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug introduced in #1107
If no
tagsare specified for an instance inhdfs_namenode.yaml, the check crashes.Temporary workaround for those that don't use tags and are having this problem is to set
tags: []in your instance yaml.Motivation
Our HDFS Namenode check was crashing.