Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecations.py extra new line #11020

Closed
wants to merge 1 commit into from
Closed

Fix deprecations.py extra new line #11020

wants to merge 1 commit into from

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Jan 4, 2022 •
edited
Loading

What does this PR do?

Fix deprecations.py extra new line

Motivation

./tests/models/config_models/deprecations.py:12:1: E303 too many blank lines (3)

https://dev.azure.com/datadoghq/integrations-core/_build/results?buildId=85856&view=logs&jobId=b9b61b1e-e7ad-5a75-8bb3-f1445ef55317&j=b9b61b1e-e7ad-5a75-8bb3-f1445ef55317&t=7c089b75-bae3-5b60-6359-24783737f19d

Lint issue introduced here #10945

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@AlexandreYang AlexandreYang requested review from a team as code owners January 4, 2022 16:32
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

AlexandreYang
AlexandreYang commented Jan 4, 2022
View reviewed changes
datadog_checks_base/tests/models/config_models/deprecations.py
@@ -8,7 +8,6 @@
# ddev -x validate models -s <INTEGRATION_NAME>



Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, it seems that ddev validate models datadog_checks_base -s will add the new line back 🤔

@AlexandreYang AlexandreYang deleted the alex/base_fix_deprecations_py branch January 4, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog/no-changelog integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AlexandreYang