Don't add autogenerated comments to deprecation files #11014

sarah-witt · 2022-01-03T22:58:11Z

What does this PR do?

Don't add autogenerated comments to deprecation files

Motivation

Both validators and deprecations are custom

Additional Notes

This was breaking the base check and mongo CI because the model syncs were conflicting with the style tests

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
PR title must be written as a CHANGELOG entry (see why)
Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
PR must have changelog/ and integration/ labels attached

github-actions · 2022-01-03T22:59:53Z

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

codecov · 2022-01-03T23:03:13Z

Codecov Report

Merging #11014 (9f418f3) into master (7444b55) will increase coverage by 0.27%.
The diff coverage is n/a.

Flag	Coverage Δ
active_directory	`100.00% <ø> (+17.64%)`	⬆️
activemq_xml	`82.31% <ø> (ø)`
airflow	`90.00% <ø> (ø)`
amazon_msk	`88.83% <ø> (ø)`
ambari	`85.75% <ø> (ø)`
apache	`95.08% <ø> (ø)`
aspdotnet	`100.00% <ø> (+26.19%)`	⬆️
avi_vantage	`91.92% <ø> (ø)`
azure_iot_edge	`82.00% <ø> (ø)`
btrfs	`82.91% <ø> (ø)`
cacti	`83.95% <ø> (ø)`
cassandra_nodetool	`94.19% <ø> (ø)`
ceph	`91.02% <ø> (ø)`
cilium	`89.74% <ø> (+1.02%)`	⬆️
cisco_aci	`95.83% <ø> (ø)`
citrix_hypervisor	`87.50% <ø> (ø)`
clickhouse	`95.63% <ø> (ø)`
cloud_foundry_api	`95.98% <ø> (+0.12%)`	⬆️
consul	`91.74% <ø> (ø)`
coredns	`95.74% <ø> (ø)`
couch	`95.19% <ø> (+0.24%)`	⬆️
couchbase	`83.46% <ø> (ø)`
crio	`89.79% <ø> (ø)`
datadog_checks_base	`90.28% <ø> (+0.32%)`	⬆️
datadog_cluster_agent	`90.00% <ø> (ø)`
directory	`94.87% <ø> (ø)`
disk	`91.61% <ø> (ø)`
dns_check	`93.84% <ø> (ø)`
dotnetclr	`94.93% <ø> (+15.18%)`	⬆️
druid	`97.70% <ø> (ø)`
ecs_fargate	`80.23% <ø> (ø)`
eks_fargate	`94.05% <ø> (ø)`
elastic	`90.52% <ø> (ø)`
envoy	`94.25% <ø> (ø)`
etcd	`93.87% <ø> (ø)`
exchange_server	`98.29% <ø> (+12.82%)`	⬆️
external_dns	`89.09% <ø> (ø)`
fluentd	`94.77% <ø> (ø)`
gearmand	`78.26% <ø> (+1.24%)`	⬆️
gitlab	`89.94% <ø> (ø)`
gitlab_runner	`91.94% <ø> (ø)`
glusterfs	`80.09% <ø> (+0.92%)`	⬆️
go_expvar	`92.73% <ø> (ø)`
gunicorn	`93.60% <ø> (ø)`
haproxy	`95.09% <ø> (+0.16%)`	⬆️
harbor	`81.29% <ø> (ø)`
hazelcast	`92.39% <ø> (ø)`
hdfs_datanode	`89.74% <ø> (ø)`
hdfs_namenode	`86.72% <ø> (ø)`
http_check	`90.98% <ø> (+1.74%)`	⬆️
ibm_i	`80.65% <ø> (ø)`
ibm_mq	`89.67% <ø> (ø)`
ibm_was	`96.06% <ø> (ø)`
iis	`94.91% <ø> (+38.49%)`	⬆️
istio	`77.46% <ø> (+0.56%)`	⬆️
kafka_consumer	`82.66% <ø> (ø)`
kong	`88.58% <ø> (ø)`
kube_apiserver_metrics	`97.67% <ø> (ø)`
kube_controller_manager	`96.85% <ø> (ø)`
kube_dns	`98.85% <ø> (ø)`
kube_metrics_server	`100.00% <ø> (ø)`
kube_proxy	`100.00% <ø> (ø)`
kube_scheduler	`96.20% <ø> (ø)`
kubelet	`89.61% <ø> (ø)`
kyototycoon	`85.96% <ø> (ø)`
lighttpd	`83.64% <ø> (ø)`
linux_proc_extras	`96.22% <ø> (ø)`
mapr	`82.70% <ø> (ø)`
mapreduce	`81.77% <ø> (+0.46%)`	⬆️
marathon	`83.12% <ø> (ø)`
marklogic	`95.33% <ø> (ø)`
mcache	`93.52% <ø> (ø)`
mesos_master	`90.68% <ø> (ø)`
mesos_slave	`93.63% <ø> (ø)`
mongo	`94.54% <ø> (+0.27%)`	⬆️
nagios	`89.53% <ø> (ø)`
network	`77.76% <ø> (+1.00%)`	⬆️
nfsstat	`95.20% <ø> (ø)`
nginx	`95.27% <ø> (+0.55%)`	⬆️
nginx_ingress_controller	`98.36% <ø> (ø)`
openldap	`96.33% <ø> (ø)`
openmetrics	`97.14% <ø> (ø)`
openstack	`51.45% <ø> (ø)`
openstack_controller	`90.74% <ø> (ø)`
oracle	`92.58% <ø> (+2.69%)`	⬆️
pgbouncer	`90.45% <ø> (ø)`
php_fpm	`90.25% <ø> (+0.46%)`	⬆️
postfix	`88.04% <ø> (ø)`
powerdns_recursor	`96.65% <ø> (ø)`
process	`85.07% <ø> (+0.28%)`	⬆️
prometheus	`94.17% <ø> (ø)`
proxysql	`98.97% <ø> (ø)`
rabbitmq	`94.40% <ø> (ø)`
redisdb	`87.44% <ø> (ø)`
rethinkdb	`97.93% <ø> (ø)`
riakcs	`93.61% <ø> (ø)`
scylla	`100.00% <ø> (ø)`
singlestore	`90.81% <ø> (ø)`
snowflake	`93.60% <ø> (ø)`
sonarqube	`95.69% <ø> (ø)`
squid	`100.00% <ø> (ø)`
ssh_check	`91.58% <ø> (ø)`
statsd	`87.36% <ø> (+4.21%)`	⬆️
supervisord	`92.30% <ø> (ø)`
system_core	`91.04% <ø> (ø)`
system_swap	`98.30% <ø> (ø)`
tcp_check	`89.83% <ø> (ø)`
teamcity	`80.00% <ø> (ø)`
tls	`97.04% <ø> (+0.87%)`	⬆️
tokumx	`58.40% <ø> (?)`
twemproxy	`78.33% <ø> (ø)`
twistlock	`79.62% <ø> (ø)`
vault	`95.04% <ø> (+0.55%)`	⬆️
vsphere	`89.75% <ø> (+0.05%)`	⬆️
win32_event_log	`86.03% <ø> (+0.28%)`	⬆️
windows_performance_counters	`98.36% <ø> (ø)`
wmi_check	`92.91% <ø> (ø)`
yarn	`89.85% <ø> (ø)`
zk	`86.04% <ø> (+0.46%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

github-actions · 2022-01-03T23:07:35Z

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions · 2022-01-03T23:09:26Z

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions · 2022-01-03T23:38:54Z

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions · 2022-01-04T15:58:00Z

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions · 2022-01-04T16:32:49Z

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

* Don't add autogenerated comments to deprecation files * Remove comment from file * remove comment from base test * Don't add extra space * Revert date changes * Style

Don't add autogenerated comments to deprecation files

efeab7c

sarah-witt requested a review from a team as a code owner January 3, 2022 22:58

ghost added dev/tooling integration/datadog_checks_dev integration/mongo labels Jan 3, 2022

sarah-witt added the changelog/Fixed label Jan 3, 2022

sarah-witt added 2 commits January 3, 2022 18:05

Remove comment from file

6bbb742

remove comment from base test

ac12f79

sarah-witt requested a review from a team as a code owner January 3, 2022 23:07

ghost added the integration/datadog_checks_base label Jan 3, 2022

Don't add extra space

5a15167

coignetp previously approved these changes Jan 4, 2022

View reviewed changes

Revert date changes

48b0e7f

sarah-witt dismissed coignetp’s stale review via 48b0e7f January 4, 2022 15:56

sarah-witt requested a review from coignetp January 4, 2022 15:57

Style

9f418f3

hithwen approved these changes Jan 4, 2022

View reviewed changes

coignetp approved these changes Jan 4, 2022

View reviewed changes

ofek approved these changes Jan 4, 2022

View reviewed changes

sarah-witt merged commit 0cb7317 into master Jan 4, 2022

sarah-witt deleted the sarah/sync-mongo-config branch January 4, 2022 17:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't add autogenerated comments to deprecation files #11014

Don't add autogenerated comments to deprecation files #11014

sarah-witt commented Jan 3, 2022 •

edited

Loading

github-actions bot commented Jan 3, 2022

codecov bot commented Jan 3, 2022 •

edited

Loading

github-actions bot commented Jan 3, 2022

github-actions bot commented Jan 3, 2022

github-actions bot commented Jan 3, 2022

github-actions bot commented Jan 4, 2022

github-actions bot commented Jan 4, 2022

Don't add autogenerated comments to deprecation files #11014

Don't add autogenerated comments to deprecation files #11014

Conversation

sarah-witt commented Jan 3, 2022 • edited Loading

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

github-actions bot commented Jan 3, 2022

codecov bot commented Jan 3, 2022 • edited Loading

Codecov Report

github-actions bot commented Jan 3, 2022

github-actions bot commented Jan 3, 2022

github-actions bot commented Jan 3, 2022

github-actions bot commented Jan 4, 2022

github-actions bot commented Jan 4, 2022

sarah-witt commented Jan 3, 2022 •

edited

Loading

codecov bot commented Jan 3, 2022 •

edited

Loading