Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add statement metadata to events and metrics payload #10880

Merged
merged 22 commits into from
Jan 6, 2022
Merged

Add statement metadata to events and metrics payload #10880

merged 22 commits into from
Jan 6, 2022

Conversation

alexbarksdale
Copy link
Member

What does this PR do?

Add metadata about a SQL statement in the event payloads. More information regarding these changes can be found in the agent PR.

Agent: DataDog/datadog-agent#10042

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@alexbarksdale alexbarksdale requested review from a team as code owners December 16, 2021 04:52
@alexbarksdale alexbarksdale mentioned this pull request Dec 16, 2021
Merged
8 tasks
@alexbarksdale alexbarksdale mentioned this pull request Dec 16, 2021
Closed
4 tasks
@alexbarksdale alexbarksdale requested review from joelmarcotte and removed request for joelmarcotte December 16, 2021 19:44
Base automatically changed from alex.barksdale/obfuscate-sql-lib to master January 3, 2022 23:20
@sarah-witt sarah-witt requested a review from a team as a code owner January 3, 2022 23:20
@codecov
Copy link

codecov bot commented Jan 4, 2022 •
edited
Loading

Codecov Report

Merging #10880 (2c7687f) into master (32a4d58) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Flag Coverage Δ
mysql 87.53% <100.00%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@alexbarksdale alexbarksdale merged commit a4d96c9 into master Jan 6, 2022
@alexbarksdale alexbarksdale deleted the alex.barksdale/mysql-add-metadata branch January 6, 2022 20:11
@yzhan289 yzhan289 changed the title mysql: Add statement metadata to events and metrics payload Add statement metadata to events and metrics payload Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-normand alexandre-normand alexandre-normand approved these changes

Assignees
No one assigned
Labels
documentation integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexbarksdale @alexandre-normand