Add the option to set a reported hostname (MySQL) #10687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sarina-dd
previously approved these changes
Nov 19, 2021
alexbarksdale
changed the title
justiniso
reviewed
Nov 22, 2021
mysql/assets/configuration/spec.yaml
Outdated
| @@ -50,6 +50,12 @@ files: | |||
| type: number | |||
| example: 3306 | |||
|
|
|||
| - name: reported_hostname | |||
| description: | | |||
| Set the reported hostname for this instance. | |||
There was a problem hiding this comment.
See my note here: #10682 (comment)
justiniso
previously approved these changes
Nov 22, 2021
sarina-dd
previously approved these changes
Nov 22, 2021
hithwen
previously approved these changes
Nov 23, 2021
alexbarksdale
dismissed stale reviews from hithwen, sarina-dd, and justiniso
via
c3acb2a
jmeunier28
approved these changes
Dec 28, 2021
cswatt
pushed a commit
that referenced
this pull request
Jan 5, 2022
* Add display_hostname config option * Use configured display hostname if applicable * Add a dbm enabled case for display_hostname * Update description * Update option name to reported_hostname * Update config description * Fix merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new optional config (
display_hostname) to set the displayed hostname in MySQL. This mechanism overrides the resolved db hostname.Motivation
There are some unique cases where the resolved hostname does not (or should not) match the desired hostname.
e.g A local proxy proxying ports to multiple instances or the host is an IP address.
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached