Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use_mount required field #10657

Merged
merged 4 commits into from
Nov 16, 2021
Merged

Fix use_mount required field #10657

merged 4 commits into from
Nov 16, 2021

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

use_mount defaults to False, adding the required field makes the tests fail when use_mount is not explicitly defined in conf.yaml

Motivation

Fix behavior

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen added changelog/Fixed category/bugfix For use during Agent Release period labels Nov 16, 2021
@ChristineTChen ChristineTChen requested review from a team as code owners November 16, 2021 22:05
@codecov
Copy link

codecov bot commented Nov 16, 2021 •
edited
Loading

Codecov Report

Merging #10657 (88a7044) into master (2824dc9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
disk 91.13% <100.00%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@fanny-jiang fanny-jiang merged commit 87b9956 into master Nov 16, 2021
@fanny-jiang fanny-jiang deleted the cc/disk-dd-run branch November 16, 2021 22:51
github-actions bot pushed a commit that referenced this pull request Nov 16, 2021
@fanny-jiang
Fix use_mount required field (#10657)
74fbebb 
* Use dd_run_check in tests

* Add dd_run_check

* Sync use_mount change

* Enable option 87b9956
fanny-jiang pushed a commit that referenced this pull request Nov 16, 2021
@ChristineTChen @fanny-jiang
Fix use_mount required field (#10657)
0c54867 
* Use dd_run_check in tests

* Add dd_run_check

* Sync use_mount change

* Enable option

(cherry picked from commit 87b9956)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanny-jiang fanny-jiang fanny-jiang approved these changes

@sarah-witt sarah-witt sarah-witt approved these changes

Assignees
No one assigned
Labels
category/bugfix For use during Agent Release period documentation integration/disk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristineTChen @fanny-jiang @sarah-witt