-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hdfs_namenode] Add instance level tags to metrics and service check #1047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nitpicks 👍
hdfs_namenode/CHANGELOG.md
Outdated
@@ -1,5 +1,11 @@ | |||
# CHANGELOG - hdfs_namenode | |||
|
|||
1.1.1 / Unreleased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we adding support for instance tags it's a feature and not a bug fix: version should be 1.2.0
hdfs_namenode/CHANGELOG.md
Outdated
================== | ||
|
||
### Changes | ||
* [BUGFIX] add instance level tags to metrics and service check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add the PR number
hdfs_namenode/conf.yaml.example
Outdated
@@ -10,7 +10,9 @@ instances: | |||
# the property dfs.http.address or dfs.namenode.http-address | |||
# | |||
- hdfs_namenode_jmx_uri: http://localhost:50070 | |||
|
|||
# tags: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a small description of what tags
does, like https://github.com/DataDog/integrations-core/blob/master/mapreduce/conf.yaml.example#L23
if jmx_address is None: | ||
raise Exception('The JMX URL must be specified in the instance configuration') | ||
|
||
|
||
namenode_url = ['namenode_url:' + jmx_address] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for a intermediate namenode_url
variable, and this we're adding only 1 item we should use append
:
tags.append('namenode_url:' + jmx_address)
What does this PR do?
Adds instance level tags to both metrics and service check
Motivation
What inspired you to submit this pull request?
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Versioning
manifest.json
datadog_checks/{integration}/__init__.py
CHANGELOG.md
. Please useUnreleased
as the date in the titlefor the new section.
Additional Notes
Anything else we should know when reviewing?