[hdfs_namenode] Add instance level tags to metrics and service check #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hush-hush
requested changes
Jan 24, 2018
hdfs_namenode/CHANGELOG.md
Outdated
| @@ -1,5 +1,11 @@ | |||
| # CHANGELOG - hdfs_namenode | |||
|
|
|||
| 1.1.1 / Unreleased | |||
There was a problem hiding this comment.
Since we adding support for instance tags it's a feature and not a bug fix: version should be 1.2.0
hdfs_namenode/CHANGELOG.md
Outdated
| ================== | ||
|
|
||
| ### Changes | ||
| * [BUGFIX] add instance level tags to metrics and service check |
hdfs_namenode/conf.yaml.example
Outdated
| @@ -10,7 +10,9 @@ instances: | |||
| # the property dfs.http.address or dfs.namenode.http-address | |||
| # | |||
| - hdfs_namenode_jmx_uri: http://localhost:50070 | |||
|
|
|||
| # tags: | |||
There was a problem hiding this comment.
We should add a small description of what tags does, like https://github.com/DataDog/integrations-core/blob/master/mapreduce/conf.yaml.example#L23
| if jmx_address is None: | ||
| raise Exception('The JMX URL must be specified in the instance configuration') | ||
|
|
||
|
|
||
| namenode_url = ['namenode_url:' + jmx_address] |
There was a problem hiding this comment.
No need for a intermediate namenode_url variable, and this we're adding only 1 item we should use append:
tags.append('namenode_url:' + jmx_address)
hush-hush
approved these changes
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds instance level tags to both metrics and service check
Motivation
What inspired you to submit this pull request?
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Versioning
manifest.jsondatadog_checks/{integration}/__init__.pyCHANGELOG.md. Please useUnreleasedas the date in the titlefor the new section.
Additional Notes
Anything else we should know when reviewing?