[disk] Fix tag_by_label when used together with use_mount
#10418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `tag_by_label` is set and `use_mount` is set, we would end up accessing the labels array by mountpoint instead of the actual device path.
ghost
added
the
mx-psi
approved these changes
Oct 15, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Oct 18, 2021
If tag_by_label and use_mount were both set, we would end up accessing the devices_label array by mountpoint instead of the actual device path. 4c3d9fa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
devices_labelusing the wrong key (ie: the mountpoint instead of the device name)Motivation
If
tag_by_labelanduse_mountwere both set, we would end up accessingthe
devices_labelarray by mountpoint instead of the actual device path.