Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to override default IBM i hostname #10383

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 8, 2021

What does this PR do?

Add hostname field to instance configuration; it allows users to override the default IBM i hostname for a given machine.

Motivation

Customer request.

Additional Notes

OpenAPI supports the hostname format, but

so I decided to go with a simple length check.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #10383 (67eb80f) into master (d22a79e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
ibm_i 80.85% <100.00%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mx-psi mx-psi marked this pull request as ready for review October 8, 2021 14:53
@mx-psi mx-psi requested review from a team as code owners October 8, 2021 14:53
Copy link
Contributor

@KSerrania KSerrania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mx-psi mx-psi merged commit c40e100 into master Oct 15, 2021
@mx-psi mx-psi deleted the mx-psi/ibm-i-hostname branch October 15, 2021 07:29
@mx-psi mx-psi restored the mx-psi/ibm-i-hostname branch October 15, 2021 07:29
@dd-devflow dd-devflow bot deleted the mx-psi/ibm-i-hostname branch February 7, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants