Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log exceptions for troubleshooting #10368

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Log exceptions for troubleshooting #10368

merged 2 commits into from
Oct 15, 2021

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 7, 2021

What does this PR do?

Adds logging when some previously ignored exceptions happen.

Motivation

Help in troubleshooting.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ghost ghost added the integration/ibm_i label Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021 •
edited
Loading

Codecov Report

Merging #10368 (1bb9d49) into master (427adbb) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Flag Coverage Δ
ibm_i 80.65% <33.33%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mx-psi mx-psi marked this pull request as ready for review October 7, 2021 11:03
@mx-psi mx-psi requested review from a team as code owners October 7, 2021 11:03
yzhan289
yzhan289 previously approved these changes Oct 7, 2021
View reviewed changes
albertvaka
albertvaka previously approved these changes Oct 7, 2021
View reviewed changes
mx-psi added a commit that referenced this pull request Oct 12, 2021
@mx-psi
[ibm_i] Log exceptions for troubleshooting (#10368)
9cfc941
@mx-psi mx-psi dismissed stale reviews from albertvaka and yzhan289 via 1bb9d49 October 15, 2021 08:02
@mx-psi mx-psi merged commit b11558c into master Oct 15, 2021
@mx-psi mx-psi deleted the mx-psi/log-exceptions-ibm-i branch October 15, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KSerrania KSerrania KSerrania approved these changes

@albertvaka albertvaka albertvaka left review comments

@yzhan289 yzhan289 yzhan289 left review comments

Assignees
No one assigned
Labels
integration/ibm_i
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mx-psi @albertvaka @KSerrania @yzhan289