-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove server
from the list of generic tags
#10344
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f03660c.
ofek
changed the title
Revert "Add server as generic tag (#10100)"
Remove Oct 5, 2021
server
from the list of generic tags
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
ChristineTChen
previously approved these changes
Oct 5, 2021
ChristineTChen
approved these changes
Oct 5, 2021
github-actions bot
pushed a commit
to jeroenj/integrations-core
that referenced
this pull request
Oct 6, 2021
* Revert "Add server as generic tag (DataDog#10100)" This reverts commit f03660c. * revert DataDog#10164 feff48d
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This reverts commit f03660c, so only reserved tags are considered generic.
Motivation
We have an RFC to decide how to handle such tagging in the future so we should avoid any premature implementation of such enforcement.
Additional Notes
The 2 integrations where we didn't want a
server
tag are unaffected by this change: