Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove server from the list of generic tags #10344

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Oct 5, 2021

What does this PR do?

This reverts commit f03660c, so only reserved tags are considered generic.

Motivation

We have an RFC to decide how to handle such tagging in the future so we should avoid any premature implementation of such enforcement.

Additional Notes

The 2 integrations where we didn't want a server tag are unaffected by this change:

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #10344 (d94e05c) into master (f8e88fe) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Flag Coverage Δ
active_directory 100.00% <ø> (ø)
activemq_xml 82.31% <ø> (ø)
aerospike 86.97% <ø> (+0.36%) ⬆️
airflow 90.00% <ø> (ø)
amazon_msk 86.63% <ø> (ø)
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
aspdotnet 93.87% <ø> (ø)
avi_vantage 91.92% <100.00%> (-0.05%) ⬇️
azure_iot_edge 82.01% <ø> (ø)
btrfs 82.91% <ø> (ø)
cacti 83.95% <ø> (ø)
cassandra_nodetool 94.19% <ø> (ø)
ceph 91.02% <ø> (ø)
cilium 85.84% <ø> (+1.88%) ⬆️
cisco_aci 95.85% <ø> (ø)
citrix_hypervisor 87.50% <ø> (ø)
clickhouse 96.65% <ø> (ø)
cloud_foundry_api 95.98% <ø> (+0.12%) ⬆️
cockroachdb 97.18% <ø> (ø)
consul 91.74% <ø> (ø)
coredns 95.74% <ø> (ø)
couch 95.19% <ø> (+0.24%) ⬆️
couchbase 81.45% <ø> (ø)
crio 100.00% <ø> (ø)
datadog_checks_base 89.64% <ø> (+0.40%) ⬆️
datadog_checks_dev 79.86% <ø> (ø)
datadog_cluster_agent 97.50% <ø> (ø)
directory 94.87% <ø> (ø)
disk 91.15% <ø> (-0.49%) ⬇️
dns_check 94.00% <ø> (ø)
dotnetclr 100.00% <ø> (ø)
druid 97.70% <ø> (ø)
ecs_fargate 73.60% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
elastic 88.65% <ø> (ø)
envoy 93.90% <ø> (ø)
etcd 93.09% <ø> (ø)
exchange_server 100.00% <ø> (ø)
external_dns 100.00% <ø> (ø)
fluentd 94.77% <ø> (ø)
gearmand 77.27% <ø> (+1.29%) ⬆️
gitlab 89.94% <ø> (ø)
gitlab_runner 91.94% <ø> (ø)
glusterfs 80.09% <ø> (+0.92%) ⬆️
gunicorn 93.60% <ø> (+0.75%) ⬆️
haproxy 95.08% <ø> (+0.16%) ⬆️
harbor 81.29% <ø> (ø)
hazelcast 92.39% <ø> (ø)
hdfs_datanode 89.30% <ø> (ø)
hdfs_namenode 87.01% <ø> (ø)
http_check 90.37% <ø> (+1.80%) ⬆️
ibm_db2 94.79% <ø> (?)
ibm_i 80.05% <ø> (ø)
ibm_mq 89.45% <ø> (ø)
ibm_was 97.45% <ø> (ø)
iis 93.01% <ø> (ø)
istio 77.67% <ø> (+0.59%) ⬆️
kafka_consumer 81.65% <ø> (ø)
kong 92.21% <ø> (ø)
kube_apiserver_metrics 97.35% <ø> (ø)
kube_controller_manager 96.85% <ø> (ø)
kube_dns 98.85% <ø> (ø)
kube_metrics_server 100.00% <ø> (ø)
kube_proxy 100.00% <ø> (ø)
kube_scheduler 96.20% <ø> (ø)
kubelet 89.61% <ø> (ø)
kubernetes_state 89.67% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linkerd 85.14% <ø> (+1.14%) ⬆️
mapr 82.62% <ø> (ø)
mapreduce 81.77% <ø> (+0.46%) ⬆️
marathon 83.12% <ø> (ø)
marklogic 95.33% <ø> (ø)
mcache 93.48% <ø> (ø)
mesos_master 90.68% <ø> (ø)
mesos_slave 93.63% <ø> (ø)
mongo 94.64% <ø> (+0.49%) ⬆️
mysql 86.62% <ø> (+0.27%) ⬆️
nagios 89.53% <ø> (ø)
network 77.76% <ø> (+1.00%) ⬆️
nfsstat 95.20% <ø> (ø)
nginx 94.62% <ø> (+0.86%) ⬆️
nginx_ingress_controller 98.30% <ø> (ø)
openmetrics 97.14% <ø> (ø)
openstack 51.30% <ø> (ø)
openstack_controller 90.74% <ø> (ø)
oracle 93.65% <ø> (+0.52%) ⬆️
pdh_check 97.77% <ø> (ø)
pgbouncer 90.45% <ø> (ø)
php_fpm 90.04% <ø> (+0.43%) ⬆️
postfix 88.04% <ø> (ø)
postgres 91.60% <ø> (+0.04%) ⬆️
powerdns_recursor 96.65% <ø> (ø)
process 85.07% <ø> (ø)
prometheus 94.17% <ø> (ø)
proxysql 98.97% <ø> (ø)
rabbitmq 94.40% <ø> (ø)
redisdb 87.28% <ø> (ø)
rethinkdb 97.93% <ø> (ø)
riak 99.22% <ø> (ø)
riakcs 93.61% <ø> (ø)
sap_hana 91.99% <ø> (ø)
scylla 100.00% <ø> (ø)
singlestore 90.81% <ø> (ø)
snmp 90.56% <ø> (+0.04%) ⬆️
snowflake 93.48% <ø> (ø)
sonarqube 95.69% <ø> (ø)
spark 93.41% <ø> (+0.19%) ⬆️
sqlserver 84.25% <ø> (ø)
squid 100.00% <ø> (ø)
ssh_check 91.58% <ø> (ø)
statsd 87.36% <ø> (+1.05%) ⬆️
supervisord 92.30% <ø> (ø)
system_core 91.04% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 88.83% <ø> (ø)
teamcity 80.00% <ø> (ø)
tls 97.04% <ø> (+0.87%) ⬆️
tokumx 58.40% <ø> (?)
twemproxy 78.33% <ø> (ø)
twistlock 80.25% <ø> (ø)
varnish 84.57% <ø> (+0.24%) ⬆️
vault 95.00% <ø> (+0.55%) ⬆️
vertica 92.33% <ø> (ø)
voltdb 96.81% <ø> (ø)
vsphere 89.78% <ø> (+0.08%) ⬆️
win32_event_log 86.03% <ø> (+0.28%) ⬆️
windows_service 95.83% <ø> (ø)
wmi_check 92.91% <ø> (ø)
yarn 89.85% <ø> (ø)
zk 84.96% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

ChristineTChen
ChristineTChen previously approved these changes Oct 5, 2021
@sarah-witt sarah-witt merged commit feff48d into master Oct 5, 2021
@sarah-witt sarah-witt deleted the ofek/server-tag branch October 5, 2021 21:17
github-actions bot pushed a commit to jeroenj/integrations-core that referenced this pull request Oct 6, 2021
* Revert "Add server as generic tag (DataDog#10100)"

This reverts commit f03660c.

* revert DataDog#10164 feff48d
@coignetp coignetp mentioned this pull request Oct 11, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment