Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PGBouncer] Adds support for 1.8 new metrics #1011

Closed
wants to merge 6 commits into from

Conversation

nmuesch
Copy link
Collaborator

@nmuesch nmuesch commented Jan 14, 2018

What does this PR do?

Pulls in PGBouncer column names when running query to more easily identify available metrics. Adds in new metrics to be submitted.

Motivation

Users ran into an issue when using PGBouncer 1.8. There are now more metrics available for "SHOW STATS" and "SHOW POOLS"

Previous metrics available - http://web.archive.org/web/20170623115443/https://pgbouncer.github.io/usage.html
Newly available metrics - https://pgbouncer.github.io/usage.html

Since we were indexing the columns using a specific order, the addition of new metrics caused the check to crash.

Testing Guidelines

An overview on testing
is available in our contribution guidelines.

Versioning

  • Bumped the check version in manifest.json
  • Bumped the check version in datadog_checks/{integration}/__init__.py
  • Updated CHANGELOG.md. Please use Unreleased as the date in the title
    for the new section.

Additional Notes

Instead of just submitting every column available as a metric, I continue to use the SHOW STATS and SHOW POOLS object so that we have a finer control over what metric names and types are when they are submitted. Should future versions provide additional metrics, or change names, we just need to add to those two objects.

Finally, some metric names changed between pre 1.8 and post. Due to this, there may be duplicate metric names in the SHOW STATS object, but with different key/column names.

@nmuesch nmuesch changed the title [PGBouncer][WIP] Adds support for 1.8 new metrics [PGBouncer] Adds support for 1.8 new metrics Jan 15, 2018
@nmuesch
Copy link
Collaborator Author

nmuesch commented Jan 17, 2018

Closing in favor of #1016

@nmuesch nmuesch closed this Jan 17, 2018
@nmuesch nmuesch deleted the nick/update_pgbouncer_for_1.8 branch January 17, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant