Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop snowflake support from py2, bump requests #10105

Merged
merged 5 commits into from
Sep 22, 2021

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Sep 13, 2021

This PR drops support for snowflake integration on Python 2 as it prevents us from using the latests requests library, which includes security fixes.

Omnibus PR DataDog/datadog-agent#9202

@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #10105 (8a833a5) into master (07dd8fe) will increase coverage by 0.05%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_base 89.67% <ø> (+0.37%) ⬆️
snowflake 93.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

djmitche
djmitche previously approved these changes Sep 13, 2021
@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link
Contributor

@coignetp coignetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hithwen hithwen merged commit de3d652 into master Sep 22, 2021
@hithwen hithwen deleted the js/drop-snowflake-from-py3 branch September 22, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants