-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max_client_conn metric #10033
Add max_client_conn metric #10033
Conversation
So we can compute a percent of client conn used: (cl_active + cl_waiting) / max_client_conn
@blaines @FlorianVeaux @hithwen fyi :) |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
@coignetp thanks for adding the appropriate labels. It looks like a CI check failed, but I don't know why, error is:
Looks like some github action may be missing some config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening this PR! I just have a suggestion for readability
It's expected, external contributors can't run this action, I applied the labels manually |
As suggested during review. Co-authored-by: Paul <[email protected]>
@JordanP FYI this was was released in the integration version 3.1.0. It should be shipped in version Package name is |
Excellent @coignetp ! Thank you so much ! |
What does this PR do?
Add a new PGBouncer metric: max_client_conn
Motivation
So we can compute a percent of client conn used:
(cl_active + cl_waiting) / max_client_conn
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached