-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add
selected_message_queues
flag to filter message queues and impro…
…ve performances (#12808) Add selected_message_queues flag + tests
- Loading branch information
Showing
6 changed files
with
108 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# (C) Datadog, Inc. 2021-present | ||
# All rights reserved | ||
# Licensed under a 3-clause BSD style license (see LICENSE) | ||
|
||
import pytest | ||
|
||
from datadog_checks.ibm_i.config_models import InstanceConfig | ||
from datadog_checks.ibm_i.config_models.instance import MessageQueueInfo | ||
from datadog_checks.ibm_i.queries import query_map | ||
|
||
|
||
@pytest.mark.parametrize( | ||
"selected_message_queues,expected", | ||
[ | ||
( | ||
[], | ||
'SELECT MESSAGE_QUEUE_NAME, MESSAGE_QUEUE_LIBRARY, COUNT(*), SUM(CASE WHEN SEVERITY >= 50 THEN 1 ELSE 0 END) ' # noqa:E501 | ||
'FROM QSYS2.MESSAGE_QUEUE_INFO GROUP BY MESSAGE_QUEUE_NAME, MESSAGE_QUEUE_LIBRARY', | ||
), | ||
( | ||
['QSYSOPR'], | ||
'SELECT MESSAGE_QUEUE_NAME, MESSAGE_QUEUE_LIBRARY, COUNT(*), SUM(CASE WHEN SEVERITY >= 50 THEN 1 ELSE 0 END) ' # noqa:E501 | ||
'FROM QSYS2.MESSAGE_QUEUE_INFO WHERE MESSAGE_QUEUE_NAME IN (\'QSYSOPR\') GROUP BY MESSAGE_QUEUE_NAME, MESSAGE_QUEUE_LIBRARY', # noqa:E501 | ||
), | ||
( | ||
['QSYSOPR', 'QPGMR', 'CECUSER'], | ||
'SELECT MESSAGE_QUEUE_NAME, MESSAGE_QUEUE_LIBRARY, COUNT(*), SUM(CASE WHEN SEVERITY >= 50 THEN 1 ELSE 0 END) ' # noqa:E501 | ||
'FROM QSYS2.MESSAGE_QUEUE_INFO WHERE MESSAGE_QUEUE_NAME IN (\'QSYSOPR\', \'QPGMR\', \'CECUSER\') GROUP BY MESSAGE_QUEUE_NAME, MESSAGE_QUEUE_LIBRARY', # noqa:E501 | ||
), | ||
], | ||
) | ||
def test_get_message_queue_info(selected_message_queues, expected): | ||
instance_conf_attr = { | ||
"query_timeout": 1, | ||
"job_query_timeout": 2, | ||
"system_mq_query_timeout": 3, | ||
"severity_threshold": 50, | ||
} | ||
instance_conf = InstanceConfig( | ||
**instance_conf_attr, | ||
message_queue_info=MessageQueueInfo(selected_message_queues=selected_message_queues), | ||
) | ||
qmap_output = query_map(instance_conf) | ||
assert qmap_output['message_queue_info']['name'] == 'message_queue_info' | ||
assert qmap_output['message_queue_info']['columns'] == [ | ||
{'name': 'message_queue_name', 'type': 'tag'}, | ||
{'name': 'message_queue_library', 'type': 'tag'}, | ||
{'name': 'ibm_i.message_queue.size', 'type': 'gauge'}, | ||
{'name': 'ibm_i.message_queue.critical_size', 'type': 'gauge'}, | ||
] | ||
assert qmap_output['message_queue_info']['query']['text'] == expected | ||
assert qmap_output['message_queue_info']['query']['timeout'] == 3 |