Make copy

DataDog · Feb 14, 2020 · 166fdf7 · 166fdf7
1 parent 7e441e5
commit 166fdf7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/datadog_checks_base/datadog_checks/base/utils/http.py b/datadog_checks_base/datadog_checks/base/utils/http.py
@@ -306,6 +306,7 @@ def _request(self, method, url, options):
 
         extra_headers = options.pop('extra_headers', None)
         if extra_headers is not None:
+            new_options['headers'] = new_options['headers'].copy()
             new_options['headers'].update(extra_headers)
 
         with ExitStack() as stack:

diff --git a/datadog_checks_base/tests/test_http.py b/datadog_checks_base/tests/test_http.py
@@ -124,8 +124,9 @@ def test_extra_headers_on_http_method_call(self):
         init_config = {}
         http = RequestsWrapper(instance, init_config)
 
+        extra_headers = {"foo": "bar"}
         with mock.patch("requests.get") as get:
-            http.get("http://example.com/hello", extra_headers={"foo": "bar"})
+            http.get("http://example.com/hello", extra_headers=extra_headers)
 
             expected_options = {'foo': 'bar', 'User-Agent': 'Datadog Agent/0.0.0', 'answer': '42'}
             get.assert_called_with(
@@ -138,6 +139,10 @@ def test_extra_headers_on_http_method_call(self):
                 verify=True,
             )
 
+        # make sure the original headers are not modified
+        assert http.options['headers'] == {'User-Agent': 'Datadog Agent/0.0.0', 'answer': '42'}
+        assert extra_headers == {"foo": "bar"}
+
 
 class TestVerify:
     def test_config_default(self):