implement allocation free fast path for isBoolean and isNull
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-zhengda
approved these changes
Nov 9, 2024
|
@lu-zhengda feel free to merge this when you want (I don't have the rights to do so). Thanks ! |
|
@paulcacheux I've pushed a new tag |
|
thanks a lot ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example profile where those 2 small functions end up representing 6% of the total allocations of the agent.
I was surprised those functions even allocate in the first place, but it makes sense because of the case insensitive nature of the check. To improve a bit the situation, this PR adds some allocation free fast paths, checking directly for the most common cases (all lower or all upper cases).