Added option to remove spaces between parentheses #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-normand
approved these changes
Oct 26, 2023
| @@ -899,6 +939,38 @@ func TestNormalizerStoredProcedure(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestNormalizerWithoutSpaceBetweenParentheses(t *testing.T) { | |||
There was a problem hiding this comment.
I think this looks good but we might want to refactor the tests eventually to have test cases with input, expected and a set of options. That way, tests can be collocated for the same input but with different options and really clearly show the difference in expected result depending on those options.
There was a problem hiding this comment.
yeah that is on my list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new normalizer option
RemoveSpaceBetweenParenthesesthat let user get rid of the additional spaces inserted between parentheses. The space was added initially for backward compatibility purpose.The the option set to true, a normalized query will no longer have extra space between parentheses such as
xx in ( ? ). Instead, the normalized output will bexx in (?).