Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly tokenize file# #21

Merged
merged 1 commit into from
Oct 26, 2023
Merged

correctly tokenize file# #21

merged 1 commit into from
Oct 26, 2023

Conversation

lu-zhengda
Copy link
Collaborator

The tokenizer incorrectly tokenize file# into 2 tokens file and #. This causes query like select file# being normalized into weird format select file #.

@lu-zhengda lu-zhengda marked this pull request as ready for review October 26, 2023 15:22
@lu-zhengda lu-zhengda requested a review from a team as a code owner October 26, 2023 15:22
@lu-zhengda lu-zhengda merged commit e1959e2 into main Oct 26, 2023
3 checks passed
@lu-zhengda lu-zhengda deleted the zhengda.lu/oracle branch October 26, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-normand alexandre-normand alexandre-normand approved these changes

@nenadnoveljic nenadnoveljic Awaiting requested review from nenadnoveljic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lu-zhengda @alexandre-normand