trim quotes for collected metadata #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -240,3 +240,8 @@ func replaceDigits(input string, placeholder string) string { | |||
|
|
|||
| return builder.String() | |||
| } | |||
|
|
|||
| func trimQuotes(input string, delim string, closingDelim string) string { | |||
| replacer := strings.NewReplacer(delim, "", closingDelim, "") | |||
There was a problem hiding this comment.
We could probably move the replacer to a global variable initialized via func init()? Not a big deal but it would save on the cost of building the replacer instance.
There was a problem hiding this comment.
I thought about that but the replacer is a bit dynamic, which depends on the opening and closing delimiter, such as " or [|]. One way of doing that is create all possible replacers as global var and retrieve based on delimiter.
There was a problem hiding this comment.
Oh sorry, I missed that. Yeah, I guess you could keep a mapping of replacers by delimiters but it might be becoming more tedious than it's worth. I think it's fine as-is.
alexandre-normand
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR trims quotes for quoted identifiers before collecting metadata.
This change is necessary as metadata are often processed as tags, table name tag like
\"public\".\"users\"with double quotes in string will be processed as tagtable:_public_._table_.Worth to mention, we only want to trim the quotes for collected metadata but retain the exact format in obfuscated and normalized queries.
(Per best practice, tags
May contain alphanumerics, underscores, minuses, colons, periods, and slashes. Other characters are converted to underscores.)