remove regex based normalization #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normalizer.go
Outdated
| @@ -60,6 +60,10 @@ type StatementMetadata struct { | |||
| Commands []string | |||
| } | |||
|
|
|||
| type GroupablePlaceholder struct { | |||
There was a problem hiding this comment.
Does this need to be an exported type?
There was a problem hiding this comment.
good call. no need to be exportable
alexandre-normand
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all regex uses in normalization including
Although regex implementation is easy to write (with help from ChatGPT) and understand, the non-regex approach yields better performance.
Additionally, the PR also pass token pointer to normalizeSQL function to reduce memory usage.