feat(lib): use memfd on linux instead of dumping libddwaf.so in /tmp #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Signed-off-by: Eliott Bouhana <[email protected]>
eliottness
force-pushed
the
eliott.bouhana/memfd
branch
from
c840ba3 to
5048c4c
Compare
keisku
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Can you update this documentation as well? Thank you!
Lines 128 to 137 in 48f7206
Signed-off-by: Eliott Bouhana <[email protected]>
keisku
reviewed
Sep 4, 2024
| // The caller is responsible for calling wafDl.Close on the returned object once they | ||
| // are done with it so that associated resources can be released. | ||
| func NewWafDl() (dl *WafDl, err error) { | ||
| file, err := lib.DumpEmbeddedWAF() | ||
| path, closer, err := lib.DumpEmbeddedWAF() | ||
| if err != nil { | ||
| return |
There was a problem hiding this comment.
Should we not ignore this err?
Suggested change
| return | |
| return nil, fmt.Errorf("write an embedded WAF library: %w", err) |
There was a problem hiding this comment.
Ah sh*t. Should have disabled auto-merge when I saw your comments. Don't worry I will do it in another PR
| } | ||
| }() | ||
|
|
||
| var handle uintptr | ||
| if handle, err = purego.Dlopen(file, purego.RTLD_GLOBAL|purego.RTLD_NOW); err != nil { | ||
| if handle, err = purego.Dlopen(path, purego.RTLD_GLOBAL|purego.RTLD_NOW); err != nil { | ||
| return |
There was a problem hiding this comment.
Suggested change
| return | |
| return nil, fmt.Errorf("dlopen: %w", err) |
Julio-Guerra
approved these changes
Sep 4, 2024
eliottness
pushed a commit
that referenced
this pull request
Sep 4, 2024
Context: #106 (comment) I am doing this on behave of @eliottness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR refactors the code in
internal/libto accommodate two implementations of theDumpEmbeddedWAF()function. One for linux usingmemfd, ultimately callingdlopen("/proc/self/fd/{fd}"), and one for darwin still creating a temporary file and callingdlopen("/tmp/libddwaf-*.so").Side quest: some function comments were not starting by the name of the function, fixed it.
Motivation
Being able to use dd-trace-go on full read-only filesystems. On linux only for now but still