Some WeakDmaFile fixes #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlovich
force-pushed
the
fix-weak-file-export
branch
3 times, most recently
from
eba5990 to
9d4642e
Compare
vlovich
changed the title
Missing from exports. Also missing were default and new constructor methods as well as strong_count.
glommer
force-pushed
the
fix-weak-file-export
branch
from
9d4642e to
1050772
Compare
glommer
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WeakDmaFile is exported as was intended. Additionally expose
strong_countfor debug logging.Motivation
Tried to reference WeakDmaFile explicitly but the type can only be used implicitly via
downgrade.Related issues
Additional Notes
Checklist
[X] I have added unit tests to the code I am submitting
[X] My unit tests cover both failure and success scenarios
[] If applicable, I have discussed my architecture