Generate a PodTemplate for each EDS #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 51.24% 51.90% +0.66%
==========================================
Files 39 41 +2
Lines 2096 2175 +79
==========================================
+ Hits 1074 1129 +55
- Misses 938 954 +16
- Partials 84 92 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Generate a PodTemplate for each EDS as preparation for kubernetes/autoscaler#3964
Motivation
Read kubernetes/autoscaler#3873 for context
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Deploy a
EDSand make sure a correspondingPodTemplateobject with the same name and namespace has the same lifecycle of theEDSobject (creation/update/deletion) and has the labelcluster-autoscaler.kubernetes.io/daemonset-pod=true