Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update profiling namespacing for ddtrace 1.0 #12912

Closed
wants to merge 2 commits into from
Closed

Update profiling namespacing for ddtrace 1.0 #12912

wants to merge 2 commits into from

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jan 25, 2022 •
edited
Loading

What does this PR do?

This PR updates the profiler require path after changes to ddtrace's namespacing scheme in the coming 1.0 release: DataDog/dd-trace-rb#1849

The only namespace change applicable to our documentation is the profiler's directory being moved from ddtrace/profiling to datadog/profiling.

Preview

https://docs-staging.datadoghq.com/marcotc/namespace-profiler/tracing/profiler/enabling/ruby/

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@marcotc
Update profiling file path
b9d63f8 
This PR updates the profiler `require` path after changes to `ddtrace`'s namespacing scheme: DataDog/dd-trace-rb#1849

The only namespace change applicable here was that the profiler was moved from `ddtrace/profiling` to `datadog/profiling`.
@marcotc marcotc added the tracing Content changed in the tracing folder label Jan 25, 2022
@marcotc marcotc requested a review from ivoanjo January 25, 2022 20:03
@marcotc marcotc requested a review from a team as a code owner January 25, 2022 20:03
@marcotc marcotc self-assigned this Jan 25, 2022
@marcotc marcotc mentioned this pull request Jan 25, 2022
Merged
1 task
@marcotc marcotc changed the title Update profiling file path Update profiling namespacing in ddtrace Jan 25, 2022
@marcotc marcotc changed the title Update profiling namespacing in ddtrace Update profiling namespacing in ddtrace 1.0 Jan 25, 2022
@marcotc marcotc changed the title Update profiling namespacing in ddtrace 1.0 Update profiling namespacing for ddtrace 1.0 Jan 25, 2022
@alai97
Copy link
Contributor

alai97 commented Jan 25, 2022

Documentation PR approved to merge, waiting for mid-next week!

@ivoanjo
Copy link
Member

ivoanjo commented Jan 26, 2022

Note that this shouldn't be merged until we release dd-trace-rb 1.0.0 as the new instructions will not work until we do the release.

ivoanjo
ivoanjo requested changes Feb 3, 2022
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually on closer look, that Datadog.configure block is outdated by the 1.0 configuration changes as well.

There's ongoing talk about revisiting this, but if the current 1.0 proposal stays, we'll need to update the configure block.

@alai97 alai97 added the Do Not Merge Just do not merge this PR :) label Feb 23, 2022
@marcotc
Copy link
Member Author

marcotc commented Apr 28, 2022

Superseded by #13871

@marcotc marcotc closed this Apr 28, 2022
@jtappa jtappa deleted the marcotc/namespace-profiler branch June 14, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoanjo ivoanjo ivoanjo requested changes

@alai97 alai97 alai97 approved these changes

Assignees

@marcotc marcotc

Labels
Do Not Merge Just do not merge this PR :) tracing Content changed in the tracing folder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcotc @alai97 @ivoanjo