Implement set_tag shortcut for Analytics #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
delner
force-pushed
the
feature/change_analytics_to_tag
branch
2 times, most recently
from
5a2bd9b to
43638da
Compare
delner
force-pushed
the
feature/change_analytics_to_tag
branch
from
43638da to
8f38713
Compare
palazzem
approved these changes
Mar 26, 2019
| @@ -252,3 +253,6 @@ def now_allocations | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| # Include extensions after Span (for Ruby 1.9 compatibility) | |||
| Datadog::Span.send(:include, Datadog::Analytics::Span) | |||
There was a problem hiding this comment.
That keeps the Span class way more clean, even though we still have an external dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors Analytics a bit, and adds support for
set_tag(Datadog::Ext::Analytics::TAG_ENABLED, true)to set the analytics metric to1.0as a shortcut.